Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds x-data to x-mask documentation #4326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tjbarber
Copy link

Spent more time than I'd like to admit trying to add x-mask to a field just to have it do nothing. It wasn't until I found this discussion that I realized that I was missing x-data which wasn't mentioned in the docs for this plugin.

I think it makes sense to highlight to the user that this is required, either with something like this or an alert near the top of the page.

@ekwoka
Copy link
Contributor

ekwoka commented Jul 29, 2024

The way this is done introduces the possibility of the opposite mis understanding now, where the reader thinks that x-data is always required.

Perhaps following how this pr #4307 handles it is acceptable?

@tjbarber
Copy link
Author

I would say that would be acceptable if your alert was also on x-mask documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants