fix: reset modified environment variables after test #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CustomLanguageTest was modifying a few environment variables and not restoring them when complete. This led to problems for later tests that expected those variables to be at their default values.
|
Converted to draft pending PR #221 |
|
Thanks very much! |
rgalonso
deleted the
fix/reset-environment-after-custom-language-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CustomLanguageTestwas modifying a few environment variables and not restoring them when complete. This led to problems for later tests that expected those variables to be at their default values. With this change, can now run the unit tests as described in the README (i.e.python -m unittest)