Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPad Scrolling adjusting to section when using autoScrolling:false #4602

Closed
rodrigo-arias opened this issue Jan 20, 2024 · 11 comments
Closed

Comments

@rodrigo-arias
Copy link

rodrigo-arias commented Jan 20, 2024

Description

Experiencing a bug with fullPage.js on iPad – scrolling, along with address bar dynamics, triggers unexpected readjustments. Similar to a past issue (#799). Exclusive to iPad; unaffected by fitToSection or autoScrolling tweaks.

Steps to reproduce

  1. Open fullPage.js webpage on iPad.
  2. Scroll, note address bar interaction.
  3. Observe readjustments attempting to fit sections.
  4. No issue on iPhone.
  5. Behavior persists despite fitToSection or autoScrolling changes.
Simulator.-.iPad.Air.5th.generation.mp4
Simulator.-.iPhone.14.mp4

Versions

Device: iPad
OS: iOS 17
Browser: Safari 17
fullPage.js Version: 4.0.20

@alvarotrigo
Copy link
Owner

If you are using this example for the test, that's using an old version of fullpage.js (version 2.9.7)

Are you able to reproduce the issue on the demo page?
https://alvarotrigo.com/fullPage/

Or any of the examples?

@alvarotrigo
Copy link
Owner

alvarotrigo commented Jan 20, 2024

Ok, I confirm I can reproduce it on iPad using browserstack real device on the example with autoScrolling: false:
https://alvarotrigo.com/fullPage/examples/normalScroll.html

Thanks for reporting it! 👍

@rodrigo-arias
Copy link
Author

rodrigo-arias commented Jan 20, 2024

In the demo page autoScrolling is enabled so it is not the same scenario, but I can reproduce it in Normal Scrolling or locally using the latest version of @fullpage/react-fullpage.

@alvarotrigo alvarotrigo changed the title iPad Scrolling Bug with Address Bar Interaction iPad Scrolling adjusting to section when using autoScrolling:false Jan 20, 2024
@alvarotrigo
Copy link
Owner

alvarotrigo commented Jan 20, 2024

Fixed on the dev branch 4.0.21 🥳

You can install it using npm with:

npm install alvarotrigo/fullpage.js#dev --save

@alvarotrigo
Copy link
Owner

Please confirm and I'll create the new release as soon as possible to push it to React, Vue, Angular and WordPress.

@alvarotrigo
Copy link
Owner

I've updated the files on the live page too, you might have to refresh a couple of times to avoid the cache:
https://alvarotrigo.com/fullPage/examples/normalScroll.html

@rodrigo-arias
Copy link
Author

Thanks for the quick responses and the fix! I can see a small jump in the normal scrolling example, however after updating the @fullpage/react-fullpage dist files everything looks fine locally.

Simulator.-.iPad.Air.5th.generation.mp4

@alvarotrigo
Copy link
Owner

I can see a small jump in the normal scrolling example,

Yeah that's probably the resizing of the sections to fit the new viewport that changes sizes a little bit.

@rodrigo-arias
Copy link
Author

@alvarotrigo Any chance you'll release the React patch at some point soon? A beta version would also work. Thank you

@alvarotrigo
Copy link
Owner

alvarotrigo commented Jan 30, 2024

Fixed in 4.0.21! 🥳

@alvarotrigo Any chance you'll release the React patch at some point soon? A beta version would also work. Thank you

Done!
New release available for React fullPage.js version 0.1.41
https://github.com/alvarotrigo/react-fullpage

Commit: 29681a0

@rodrigo-arias
Copy link
Author

@alvarotrigo This is working. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants