Expose PartialDateString type #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattIPv4
force-pushed
the
MattIPv4/expose-partial-date-string
branch
from
48a2162
to
9ec2df2
Compare
pjeweb
requested changes
Aug 3, 2023
There was a problem hiding this comment.
Makes sense to me. Only thing I recently learned ist that using .d.ts for “normal” types is an anti-pattern. So maybe I would probably just name it types.ts. microsoft/TypeScript#52593 (comment)
https://youtu.be/zu-EgnbmcLY
|
TIL about the implication that had for a .js file existing (gotta love that TS makes so many assumptions about .js files when it works with .ts files). |
pjeweb
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open to better ways to structure this, but wanted to have a central place to expose some of our more generic types (so they can easily be referenced from site code etc.)