Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linting #36

Closed
abdullahmorrison opened this issue Jan 23, 2023 Discussed in #35 · 0 comments
Closed

Add Linting #36

abdullahmorrison opened this issue Jan 23, 2023 Discussed in #35 · 0 comments
Labels
enhancement New feature or request refactor

Comments

@abdullahmorrison
Copy link
Contributor

Discussed in #35

Originally posted by MattIPv4 January 23, 2023
👋 What're folks thoughts on linting?

There seems to be a lot of inconsistency in the code style throughout the extension, even with basic things like whether to have a space between the start of a comment and the text in the comment, or space between a selector and its brackets.

I've generally liked to lean on eslint + stylelint, with airbnb as my default config for eslint and just relying on stylelint's standard config for SCSS.

I'd also like to add an editorconfig file (no linting), just to encourage folks' IDEs to be consistent about having newlines at the end of files, and not leaving trailing whitespace on lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

No branches or pull requests

1 participant