Add editorconfig #38
Merged
Add editorconfig #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hey @abdullahmorrison, is there anything blocking merging this in? I'd like to get this in before looking at eslint/stylelint, so I don't duplicate any work. |
|
Not been focusing much on the project lately so I haven't looked at it. I'll look at it soon. |
abdullahmorrison
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #36 (just editorconfig, not eslint or stylelint).
Adds a
.editorconfigfile to set some basic rules in place for IDEs interacting with the repo (line endings etc.).With this being added, I've cleaned up all existing violations of the config throughout the repo.
Adds a GitHub Actions workflow to check compliance with the config, and run a test build of the extension.
I updated the build script slightly to compile SCSS before it does the React build -- lmk if this isn't the proper build process.