Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12] Placing a multipart block doesn't call BlockEvent.PlaceEvent #85

Closed
raoulvdberge opened this issue Jun 29, 2017 · 1 comment
Closed

[1.12] Placing a multipart block doesn't call BlockEvent.PlaceEvent #85

raoulvdberge opened this issue Jun 29, 2017 · 1 comment

Comments

@raoulvdberge
Copy link
Contributor

This breaks my security additions to RS.
@raoulvdberge
Copy link
Contributor Author

Thx for fixing, can confirm that it works.

2xsaiko pushed a commit to 2xsaiko/MCMultiPart that referenced this issue Feb 12, 2018
@amadornes @2xsaiko
Copy-paste Forge's BlockEvent.PlaceEvent code for multiparts. Fixes a…
48f7f4d 
…madornes#85... I hope
amadornes pushed a commit that referenced this issue Feb 27, 2018
@2xsaiko @amadornes
Merge fixes from 1.12 into 1.11 (#121)
70f0ee9 
* Fix waila crash closes #92 (#97)

* Fix major part placement issues

* Copy-paste Forge's BlockEvent.PlaceEvent code for multiparts. Fixes #85... I hope

* Hopefully fixed issue with NPEs in MultipartHelper

* Oops... that wasn't supposed to be left in...

* Fix redstone interaction crashes
Not sure why these weren't a thing in the past, or whether redstone is being stupid now, but this should fix them

* Prevent crash when requesting a part from a null slot

* Properly notify neighbors of updates

* Hopefully fixed issues with parts not being aware of their world when converting from a standalone block

* Fixed yet another hidden bug - thanks Algo!

* Fix #100 (#104)

* fix #106 by making sure the part is added prior to handling the update tag (#107)

* Fix #101 (#105)

* Fix #101

* Added canPlacePartOnSide and canPlacePartAt to IMultipart

* Made canPlacePartAt check Block's methods
Added canPlaceBlockOnSide check to stack wrapper
Pass IPartSlot to canPlacePartOnSide

* Fix TEs not getting their IPartInfo set when turned into a multipart

* Implement onEntityCollidedWithBlock (needed for BC compat: Obsidian Pipes) (#108)

* This should be executable! (#109)

* canPlaceBlockAt() checks if the block is replacable. We don't wnat this for multiparts. Whoops -_- (#113)

* add check if player can destroy the block (#111)

* Allow special getSelectedBoundingBox handling (#110)

* Fix #112 (#114)

* Fix #112

* Rewrote it to use MethodHandles instead of reflection

* Network/backend rewrite (1/?) (#116)

* network rewrite (broken)

* It kinda works now?

* Only a few bugs remain!

* This seems to work reasonably well?

* Removed placement hack so that parts don't get placed on the client when they can't get placed on the server

* Inconsistencies are bad

* Re enable sorting optimization

* That message was a bit confusing

* Fix multiparts not rendering, an error when breaking Mekanism cables, and a name change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@raoulvdberge