Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly parse date skeleton EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally) #1039

Merged
merged 6 commits into from
May 2, 2024

Conversation

amannn
Copy link
Owner

@amannn amannn commented May 2, 2024

Also clarifies docs on which skeleton patterns can be used.

This increases the bundle size slightly, but being locked from upgrading the message parser isn't an option either (some dependencies like the skeleton parser were pinned by the message parser). Ultimately, we'll get rid of the ICU parser on the client side anyway: #705.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:32pm
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 1:32pm

@amannn amannn changed the title docs: Improve date time skeleton docs feat: Upgrade to intl-messageformat@10 internally May 2, 2024
@amannn amannn changed the title feat: Upgrade to intl-messageformat@10 internally fix: Upgrade to intl-messageformat@10 internally May 2, 2024
@amannn amannn changed the title fix: Upgrade to intl-messageformat@10 internally fix: Correctly parse date skeleton EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally) May 2, 2024
@amannn amannn changed the title fix: Correctly parse date skeleton EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally) fix: Correctly parse date skeleton EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally) May 2, 2024
@amannn amannn marked this pull request as ready for review May 2, 2024 13:42
@amannn amannn merged commit d6b5fd2 into main May 2, 2024
5 checks passed
@amannn amannn deleted the docs/skeleton-improvements branch May 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant