Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add example-app-router-with-next-auth-without-i18n-routing #1397

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

teplostanski
Copy link

Adding Authentication with next-auth to the example-app-router-without-i18n-routing

This pull request expands the functionality of the existing example by adding user authentication using the next-auth library. The application now supports authentication and allows you to protect routes that require authorization.

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-example-app-router ❌ Failed (Inspect) Oct 2, 2024 4:10pm
next-intl-example-app-router-without-i18n-routing ❌ Failed (Inspect) Oct 2, 2024 4:10pm

Copy link

vercel bot commented Oct 2, 2024

@teplostanski is attempting to deploy a commit to the next-intl Team on Vercel.

A member of the Team first needs to authorize it.

@amannn
Copy link
Owner

amannn commented Oct 3, 2024

Hey @teplostanski, thank you so much for proposing this example—looks like you spent quite some time on it! ❤️

That being said, the existing example-app-router-without-i18n-routing is intended to stay without an actual auth service integration to serve more as a routing inspiration. We also have another example example-app-router-next-auth that demonstrates a demo setup with Auth.js.

As examples take significant time to maintain, I'd prefer to not add another example that showcases a demonstration of both examples combined—I believe the important patterns should be covered in either example.

Have you considered though to publish your example as a separate repo under your username? I know that quite a few users are looking for a Auth.js v5 example (see #596). In this repo I'm currently waiting for the v5 stable version to drop, but in case you're interesting in upgrading your example to v5, you could link to it in the thread at #596 for example.

Hope this makes sense, keep up the good work! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants