Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add auto completion to timeZone in the Next 13 RSC branch #369

Closed
wants to merge 7 commits into from

Conversation

AhmedBaset
Copy link
Contributor

The same as #359 but for a different branch

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
example-next-13-next-auth ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 6:21pm
next-intl-example-next-13 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 6:21pm

@vercel
Copy link

vercel bot commented Jun 29, 2023

@A7med3bdulBaset is attempting to deploy a commit to the next-intl Team on Vercel.

A member of the Team first needs to authorize it.

@AhmedBaset AhmedBaset changed the title feat: Add auto completion to timeZone in the Next 13 RSC feat: Add auto completion to timeZone in the Next 13 RSC branch Jun 29, 2023
@amannn
Copy link
Owner

amannn commented Jun 30, 2023

Sorry, I think there's been some misunderstanding. What I meant in #359 (comment) is, that the RSC branch has some further usage of timeZone (e.g. in the i18n.ts config file). The branch adds new code in the packages/next-intl folder that uses the time zone as well—that was what I'm referring to.

We can get your changes from #359 into the RSC branch by rebasing, I just quickly did that.

However, I now saw that all the usage of timeZone in the branch automatically infer the new TimeZone type you've introduced due to shared types, so practically there's in fact nothing to do.

I should have been more precise and should have probably checked before, sorry for the confusion!

Thanks again for your help @A7med3bdulBaset!

@AhmedBaset
Copy link
Contributor Author

However, I now saw that all the usage of timeZone in the branch automatically infer the new TimeZone type you've introduced due to shared types, so practically there's in fact nothing to do.

That what I noticed.
You can close the PR

@amannn amannn closed this Jun 30, 2023
@AhmedBaset
Copy link
Contributor Author

Can you take a look at #365

@amannn
Copy link
Owner

amannn commented Jun 30, 2023

Yep, I have it on my list, quite busy with work these days!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants