Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: drop support for Python 3.9 #1031

Open
wants to merge 2 commits into
base: ruff_test
Choose a base branch
from
Open

infra: drop support for Python 3.9 #1031

wants to merge 2 commits into from

Conversation

math411
Copy link
Contributor

@math411 math411 commented Sep 6, 2024

Issue #, if available:

Description of changes:
This PR serves to allow Braket to start dropping support for Python 3.10. Dependencies have begun to do so. This does not serve as an immediate action but a look into what changes would take place to achieve dropped support.

Notable packages:

I have added comments within https://github.com/amazon-braket/amazon-braket-examples/blob/main/requirements.txt to highlight these during dependency upgrades.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@math411 math411 requested a review from a team as a code owner September 6, 2024 23:54
@math411 math411 changed the base branch from main to ruff_test September 6, 2024 23:54
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4e0c9f) to head (939c053).

Additional details and impacted files
@@             Coverage Diff             @@
##           ruff_test     #1031   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files            135       135           
  Lines           8998      8989    -9     
  Branches        2020      2020           
===========================================
- Hits            8998      8989    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer
Copy link
Contributor

@math411 Could you provide some more background/context on why we want to do this, given that Python 3.9 is not EOL until October 2025?

@math411
Copy link
Contributor Author

math411 commented Sep 18, 2024

@rmshaffer added in some context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants