Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MacOS build & test #343

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Jul 29, 2024

Issue #, if available: n/a

Description of changes:
This PR removes a previously added configuration that forced the use of Xcode 14.1 that was put in place due to an issue with gcc that occurred in 14.0, while Github runners were defaulting to 14.0. Xcode 14.0 has been removed from the runner images, so the build is now failing.

After this PR, builds will return to using the default Xcode.

NOTE: Both amazon linux builds are failing due to a node version update (PR incoming); ion-test-driver is failing and a fix has been posted in #344.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys
Copy link
Contributor Author

nirosys commented Jul 29, 2024

The failed amazonlinux 1 & 2 builds are a known issue (as of today). GHA is now defaulting to Node20 for running actions like checkout, and node20 is built with a newer version of glibc than is available in either amazonlinux images. There is a potential fix, that will work until node16 is removed from the image that I'll PR shortly. I'll probably remove amazonlinux:1 in that PR, since it is EOL'd as of Jan 1 2024.

ion-test-driver also failed, which is the same issue we saw previously in ion-java, will follow up with a PR for that as well.

@nirosys nirosys marked this pull request as ready for review July 29, 2024 22:09
@nirosys nirosys merged commit 4ca142b into amazon-ion:master Jul 29, 2024
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants