Adjust ASSERTs to allow zero length LOB reads #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #331
Description of changes:
This PR adjusts a couple ASSERTs in order to allow users to provide a buffer length of zero when reading LOB data.
Previously, if a user had a zero-length LOB in their data, they would need to test for zero length before reading the LOB data. Providing a zero length when reading a lob would result in an infinite loop in release builds due to this macro. This change allows the lob size to be used when reading, even if zero, potentially simplifying user code and definitely stopping surprise infinite loops.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.