Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contribute): migration #47

Merged
merged 12 commits into from
Oct 15, 2024
Merged

feat(contribute): migration #47

merged 12 commits into from
Oct 15, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Sep 12, 2024 •
edited
Loading

I migrated the contributing guide from the amber repo and the wiki page in the website (updated some urls).
Also stuff from the project readme.

When it is merged I will do a PR to change the project readme.

@Ph0enixKM
Copy link
Member

@Mte90 do we want to maintain both the CONTRIBUTING.md and the docs contributing at the same time?

@Mte90
Copy link
Member Author

Mte90 commented Sep 12, 2024

No I think that we will remove that file and in the project readme we put a link to that page in the website.

Ph0enixKM
Ph0enixKM requested changes Sep 25, 2024
View reviewed changes
docs/contribute/contribute.md Outdated Show resolved Hide resolved
docs/contribute/contribute.md Outdated Show resolved Hide resolved
docs/contribute/internals.md Outdated Show resolved Hide resolved
docs/contribute/internals.md Outdated Show resolved Hide resolved
Ph0enixKM
Ph0enixKM previously approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hdwalters
hdwalters requested changes Sep 27, 2024
View reviewed changes
docs/contribute/compiler.md Outdated Show resolved Hide resolved
docs/contribute/compiler.md Outdated Show resolved Hide resolved
docs/contribute/compiler.md Outdated Show resolved Hide resolved
docs/contribute/compiler.md Outdated Show resolved Hide resolved
docs/contribute/compiler.md Show resolved Hide resolved
docs/contribute/compiler.md Outdated Show resolved Hide resolved
docs/contribute/contribute.md Outdated Show resolved Hide resolved
docs/contribute/contribute.md Outdated Show resolved Hide resolved
docs/contribute/contribute.md Outdated Show resolved Hide resolved
docs/contribute/guide_book.md Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
amber-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 0:46am

@Mte90
Copy link
Member Author

Mte90 commented Sep 30, 2024

@hdwalters I did the various suggestions, about the rust indenting it is something we can fix later.

b1ek
b1ek previously approved these changes Oct 1, 2024
View reviewed changes
hdwalters
hdwalters previously requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@hdwalters hdwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have an uncapitalised "github". Suggest search and replace this throughout the project.

@Mte90 Mte90 requested a review from hdwalters October 2, 2024 08:18
@Mte90 Mte90 mentioned this pull request Oct 2, 2024
Merged
@Mte90 Mte90 mentioned this pull request Oct 2, 2024
Closed
hdwalters
hdwalters previously approved these changes Oct 2, 2024
View reviewed changes
@Mte90 Mte90 requested a review from b1ek October 2, 2024 15:32
@Ph0enixKM
Copy link
Member

@Mte90 I tried to change the tabs to 4 spaces but I couldn't collaborate on your branch:
image

Could you please work on the cloned version of this repository? This way I can collab on the changes. You could try adding me to your fork - perhaps this is a good alternative to it.

@Mte90
Copy link
Member Author

Mte90 commented Oct 4, 2024

I fixed the tabs/space situation.

About the access it is very strange as I can access to the other PRs and do changes.

hdwalters
hdwalters approved these changes Oct 5, 2024
View reviewed changes
Copy link
Contributor

@hdwalters hdwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tabs vs spaces debate. Scourge of developers everywhere.

@Mte90 Mte90 merged commit 9d2dda2 into amber-lang:master Oct 15, 2024
2 checks passed
@Mte90 Mte90 deleted the contribute branch October 15, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ek b1ek b1ek approved these changes

@hdwalters hdwalters hdwalters approved these changes

@Ph0enixKM Ph0enixKM Awaiting requested review from Ph0enixKM

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Local-user install instruction doesn't work
4 participants
@Mte90 @Ph0enixKM @hdwalters @b1ek