macOS install patch [updated] #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
realised it was possible to install only for local user while reading the source, and realised this rather important info was missing from the readme. tested this command, otherwise is pretty self-explanatory with what it does and how it installs for local user.
apparently under certain conditions this directory may not exists on macos. looked online to why, and by the looks of it, this dir is created when certain homebrew installs requires it to be there. now given i didn't have this dir already there, its possible for someone else to have same dir structure as me resulting in installation failure. deleted previous pr... well it got deleted on its own after i synced my fork with upstream but ehh doesnt' matter. one of the later commits cleaned the install script which caused the merge conflict. this commit fixes that.
generated this change from the systemwide amber i got installed by running my patched install.ab script two birds one stone. its confirmed my changes work B)
|
regarding why this patch was necessary, as it happens now for the most part, a user might have downloaded some xyz homebrew package that'd create this dir- fair enough, but there'd be people (like me) who wouldn't have this dir already there and hence face installation failure. |
Ph0enixKM
approved these changes
May 24, 2024
|
Dang it. It still conflicts after all the merging for today. @karshPrime can you just recompile the |
|
updated |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge conflict existed in my previous PR cause of some installation cleanup merge that happened before my merge. not a biggie I updated my patch with the new codebase and also made a change to the readme adding a copy command for local-user install.
my previous PR got deleted after I synced my fork with the upstream to get the updated code; doesn't really matter though.