Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinguish function calls that appear on the same line #169

Merged

Conversation

akihiro17
Copy link
Contributor

I add the col to the invocation_instance so that Amber can distinguish function calls that appear on the same line.

Copy link
Member

@b1ek b1ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

even though this terribly affects the code readibility, i think it should be merged so that a function can be called more than one time at one line

@Mte90
Copy link
Member

Mte90 commented Jun 20, 2024

Maybe for code readability we can do something if the Bash generated is executed with Amber itself so can parse the Bash code and give more info.

@b1ek b1ek requested review from Ph0enixKM and arapower June 21, 2024 01:38
@b1ek
Copy link
Member

b1ek commented Jun 22, 2024

@Ph0enixKM @arapower could you take a look at this?

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akihiro17 Can you resolve conflicts? I'd merge this as soon as possible and then work on the code readability. This is an urgent level bug

@akihiro17 akihiro17 force-pushed the distinguish-func-call-with-same-line branch from 747cf3c to da73523 Compare June 27, 2024 11:13
@akihiro17
Copy link
Contributor Author

@Ph0enixKM I have resolved the conflicts.

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@Ph0enixKM Ph0enixKM merged commit 1010230 into amber-lang:master Jun 28, 2024
2 checks passed
@akihiro17 akihiro17 deleted the distinguish-func-call-with-same-line branch June 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants