-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distinguish function calls that appear on the same line #169
distinguish function calls that appear on the same line #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
even though this terribly affects the code readibility, i think it should be merged so that a function can be called more than one time at one line
Maybe for code readability we can do something if the Bash generated is executed with Amber itself so can parse the Bash code and give more info. |
@Ph0enixKM @arapower could you take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akihiro17 Can you resolve conflicts? I'd merge this as soon as possible and then work on the code readability. This is an urgent level bug
747cf3c
to
da73523
Compare
@Ph0enixKM I have resolved the conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I add the
col
to theinvocation_instance
so that Amber can distinguish function calls that appear on the same line.