-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add - as placeholder for stdin/stdout #173
Conversation
How will the above command execution change after this change? |
Let's add:
amber --input [OUTPUT] # Outputs to a file
amber --input # Outputs to STDOUT
amber --input --silent # Never outputs What do you think? |
the reason for using |
I like that we offer both, |
maybe we should rather just leave it as |
I see. Okay we can use the |
So to approve this PR we need just the conflicts fixed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@b1ek To merge this let's:
- Modify the code to use the
--silence
instead - Resolve conflicts
So I tried to align the code to the latest changes, also added There aren't tests or how to use it. |
@Mte90 sorry. It should be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mte90 I clarified what I meant
Use case scenarios for the CLI:
|
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
it will still break if the user uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
Co-authored-by: Phoenix Himself <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved conflicts
Co-authored-by: Hubert Jabłoński <[email protected]>
this should be useful when amber is used like this:
also this PR adds support for
/dev/null
as an output destination: if it is/dev/null
, the compiled code will be discared (like a dry run or something)