Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): cargo #244

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(ci): cargo #244

merged 1 commit into from
Jul 1, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Jun 26, 2024 •
edited
Loading

  • Remove the building of the snap package on every PR
  • Execute the cargo build and tests from the PR and also from the push, before was executing always from the upstream master

Before:
immagine

After:
immagine

@Mte90 Mte90 requested a review from Ph0enixKM June 26, 2024 10:13
Mte90
Mte90 commented Jun 26, 2024
View reviewed changes
Copy link
Member Author

@Mte90 Mte90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works for PRs

@Mte90 Mte90 requested a review from b1ek June 26, 2024 10:13
Ph0enixKM
Ph0enixKM approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ph0enixKM Ph0enixKM merged commit 5855e70 into amber-lang:master Jul 1, 2024
2 checks passed
@Mte90 Mte90 deleted the fix-ci branch July 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b1ek b1ek b1ek approved these changes

@Ph0enixKM Ph0enixKM Ph0enixKM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mte90 @Ph0enixKM @b1ek