-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move stdlib to different files #291
Conversation
this will close #122 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think std/action
should be std/http
, since action
covers pretty much any function in stdlib, but http
covers only http related stuff, like download
which is the only thing in there
same goes for std/misc
tbh, as it only covers env related stuff. it should be std/env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some bugs found and requested changes
Once this gets merged we should update this answer: #151 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is invalid. Can you also recompile install.ab
script to see if this is working now?
@Mte90 could you resolve conflicts? |
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
Co-authored-by: Phoenix Himself <[email protected]>
The @Ph0enixKM @b1ek do you have some ideas why? |
I don't know why it doesn't work, but i think this test can be in pure amber.
this output |
Based on #152
My changes:
include_dir
crate that was missingCloses #152