-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test output as comment #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes. I'll think more about the actual implementation. I thought that we count only the comments at the top to be the output and not the comments that start with "Output". Give me some time to let that sink in
Co-authored-by: Phoenix Himself <[email protected]>
About |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this gotta be explained in CONTRIBUTING.md tho
Yes I will do that when we define how the comment is structured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Co-authored-by: Phoenix Himself <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just like i said, it gotta be explained in CONTRIBUTING.md
Based on #332 this is my proposal with some tests as example and works with multiline output.
In this way:
// Output
it will get that content for the test checkSucceded
as string for the checkI think that in this case we can simplify a lot and cover all the needs for the future.
If I get an approval I will move on to migrate (again) all the tests (also for validity) with the contribute guide.