postprocessors #383
Open
postprocessors #383
+225
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a line in the Readme about the bash dependency checker? There is already one about shfmt. |
Mte90
reviewed
Aug 5, 2024
Mte90
reviewed
Aug 5, 2024
Mte90
approved these changes
Sep 9, 2024
Ph0enixKM
requested changes
Sep 11, 2024
Comment on lines
+8
to
+20
| /// How it will pass bash code to the postprocessor | ||
| #[derive(Debug, Clone)] | ||
| pub enum PostProcessorInput { | ||
| /// Passes the data to the postprocessor's stdin | ||
| Stdin | ||
| } | ||
|
|
||
| /// How it will get the processed code from the postprocessor | ||
| #[derive(Debug, Clone)] | ||
| pub enum PostProcessorOutput { | ||
| /// Reads postprocessor's stdout | ||
| Stdout | ||
| } |
There was a problem hiding this comment.
What's the point of these? What other variants can be added here?
There was a problem hiding this comment.
like pass as an argument processor -arg "CODE" or as a file or something like that
There was a problem hiding this comment.
No but why create output enum with just stdout as variant. Same for stdin. Let's scale the code only when it needs to be scaled. Otherwise we'll have a lot of over engineered code
|
I want to report that clippy is warning about some function unused. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes code from #128 and closes #377, #149, #107, #95
the implementation is no different than the one from #128, but it also can be defined as a serializeable schema in case we want to make some sort of a config file for those.
closes #476, #377, #149, #107, #95