Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std): round and comma/dot #392

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Aug 8, 2024

Right now the tests for round on my machine doesn't work because I have configured a different language on my shell.
Italian use , instead of . as separator for decimals (like a lot of languages).
With this change we are forcing printf to use the default language that is english in the machine to avoid problems.

@Mte90
Copy link
Member Author

Mte90 commented Aug 8, 2024

This PR includes on CI the download of bc and caching also for Nix workflow.

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic.

@Ph0enixKM Ph0enixKM merged commit 2e34e15 into amber-lang:master Aug 8, 2024
1 check passed
Mte90 added a commit to Mte90/Amber that referenced this pull request Sep 19, 2024
@Mte90 Mte90 deleted the stdlib-round branch September 19, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants