Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/Bug] No stdlib comments in bash generated #408

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Ph0enixKM
Copy link
Member

No description provided.

@Ph0enixKM Ph0enixKM linked an issue Aug 13, 2024 that may be closed by this pull request
@Ph0enixKM Ph0enixKM self-assigned this Aug 13, 2024
@@ -53,6 +53,9 @@ pub fn is_functions_comment_doc(meta: &mut ParserMetadata) -> bool {
return false;
}
}
if tok.word.starts_with("#[") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this will allow to ignore comments like the function comments in stdlib?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact that function comments weren't detected was because in src/math we use preprocessor directive (#[...]) that doesn't get detected by the algorithm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the issue there was also in other stdlib stuff not just in math

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I checked this - it was everywhere were the preprocessor directive was used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing the changes on this branch, does it resolve the issues you observed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't checked if works but i saw that the comments were kept also on functions that doesn't have those attributes.

@mks-h mks-h removed their request for review August 18, 2024 12:51
@b1ek b1ek merged commit 450cfdd into master Aug 23, 2024
1 check passed
@b1ek b1ek deleted the 393-featurebug-no-stdlib-comments-in-bash-generated branch August 23, 2024 00:47
Mte90 pushed a commit to Mte90/Amber that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature/Bug] No stdlib comments in bash generated
4 participants