fix(test): missing function parameters

[Mte90]

I noticed that the tests implemented on #260 are missing in the actual release.

Probably during the various PR and changes they are gone.
This PR will implement back.

[hdwalters]

I also note trailing semicolons on some of the lines. They clearly aren't breaking any of the tests, but I didn't think they were necessary in Amber scripts?

hwalters@Wintermute ~/git/amber/src/tests (master) 
$ rg -l ';\s*$'
cli.rs
errors.rs
extra.rs
formatter.rs
mod.rs
stdlib/abs.ab
stdlib/capitalize.ab
stdlib/ceil.ab
stdlib/char_at.ab
stdlib/floor.ab
stdlib/lpad.ab
stdlib/round.ab
stdlib/rpad.ab
stdlib/slice.ab
stdlib/zfill.ab
stdlib.rs
validity.rs

[KrosFire]

Why is the default value a type? Doesn't it raise any errors while compiling?

[Mte90]

No doesn't, those are the tests for that feature that were missing after implement the feature.

[KrosFire]

I still dont understand this. Why do we allow for type to be a default value? What is the usecase?

[Mte90]

I don't know, I just migrated the test from the PR that was approved and were missing in the actual codebase.

[mks-h]

If this test succeeds, this is worth opening an issue about.

[Mte90]

tests right now works, if someone want to open a ticket about it to me is fine :-)

[Mte90]

I also note trailing semicolons on some of the lines. They clearly aren't breaking any of the tests, but I didn't think they were necessary in Amber scripts?

This are stuff for another discussion but right now there isn't any code style for amber itself.

[b1ek]

im pretty sure its supposed to be a: [Num], not a : [Num]

[Mte90]

right now the tests are working in this way, maybe is just defining a array with numbers?

[b1ek]

lgtm, just the code formatting thing

[hdwalters]

There are still a couple of issues with function_optional_argument_array.ab and function_optional_argument_array_default.ab, where you're echoing the expected value, not the value returned by the function under test. So you're asserting that 1000 equals 1000, which is probably not what you meant.

[Mte90]

Thanks everyone I just imported the test from the PR mentioned and that were missing but is clear that they had some issues and we didn't noticed when we approved it.

[hdwalters]

Looks good.

topic for another ticket