Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the process of creating new releases #92 #93

Merged
merged 10 commits into from
Jun 12, 2024

Conversation

Ph0enixKM
Copy link
Member

No description provided.

@Ph0enixKM Ph0enixKM self-assigned this May 23, 2024
@Ph0enixKM Ph0enixKM linked an issue May 23, 2024 that may be closed by this pull request
@Ph0enixKM
Copy link
Member Author

Ph0enixKM commented Jun 3, 2024

After some struggles trying to configure this on my own I gave up and got this working with cargo-dist. This automation pipeline works for:

  • Linux x86_64
  • macOS x86_64
  • macOS ARM

Unfortunately the cargo-dist does not support Linux ARM. That's the only downside.

The installer script has been adjusted to work for the new github actions pipeline. Let me know if you think we can do it better someway.

How to test this:

  1. Fork this repo or import it and merge this branch into master
  2. Update release in Cargo.toml to anything (ex. 1.1.1)
  3. Create a new release with tag that matches the Cargo.toml release.
  4. Wait for the Github Action to finish
  5. Uninstall amber if it's installed already
  6. Run the installer script with updated url variable in install.ab to match your repo url (cargo run setup/install.ab)
  7. Done ✨

@Ph0enixKM Ph0enixKM requested review from boushley and b1ek June 3, 2024 18:26
@Ph0enixKM Ph0enixKM marked this pull request as ready for review June 3, 2024 18:27
@Ph0enixKM Ph0enixKM requested review from brumik and arapower June 4, 2024 06:47
Copy link
Contributor

@arapower arapower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let's improve Linux ARM support later.

@Ph0enixKM Ph0enixKM marked this pull request as draft June 5, 2024 10:10
@Ph0enixKM
Copy link
Member Author

I'll try to compile linux arm in a separate github workflow

@Ph0enixKM
Copy link
Member Author

I managed to do this. You can test it one more time if you'd like

@Ph0enixKM Ph0enixKM marked this pull request as ready for review June 6, 2024 11:25
.github/workflows/release-linux-arm.yml Outdated Show resolved Hide resolved
.github/workflows/release-linux-arm.yml Outdated Show resolved Hide resolved
.github/workflows/release-linux-arm.yml Outdated Show resolved Hide resolved
@Ph0enixKM
Copy link
Member Author

@arapower these version changes won't introduce any breaking changes?

@Ph0enixKM
Copy link
Member Author

@arapower All issues are now resolved:

  • Upgraded actions/checkout version
  • Replaced deprecated actions/upload-release-asset with softprops/action-gh-release
  • Removed unnecessary workflow actions/upload-artifact

@Ph0enixKM
Copy link
Member Author

Ph0enixKM commented Jun 8, 2024

This PR also introduces a version bump to 0.3.2-alpha

@arapower
Copy link
Contributor

arapower commented Jun 8, 2024

@Ph0enixKM
I don't have ARM Linux, so I can't verify if the process works properly.

@Ph0enixKM
Copy link
Member Author

Ph0enixKM commented Jun 8, 2024

@arapower if the Linux ARM binary doesn't work for someone then we can adjust it later. It should though as the workflow is using cross-rs to compile it and it doesn't fail.

@arapower arapower self-requested a review June 8, 2024 12:31
Copy link
Contributor

@arapower arapower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ph0enixKM Ph0enixKM merged commit a7f8e06 into master Jun 12, 2024
1 check passed
@Ph0enixKM Ph0enixKM deleted the 92-automate-the-process-of-creating-new-releases branch June 12, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Automate the process of creating new releases
2 participants