Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init: serde feature #66

Merged
merged 4 commits into from
Nov 14, 2024
Merged

init: serde feature #66

merged 4 commits into from
Nov 14, 2024

Conversation

b1ek
Copy link
Member

@b1ek b1ek commented Oct 11, 2024

@b1ek b1ek requested a review from Ph0enixKM October 11, 2024 03:59
@Ph0enixKM
Copy link
Member

I see why this might be useful. Could you @b1ek highlight the advantages that inspired you to create this PR? I'm just curious what exact use case you want to fulfill

@b1ek
Copy link
Member Author

b1ek commented Oct 16, 2024

to serialize Messages for the amber integrated mode. potentially useful for a very wide range of other things also

@Mte90
Copy link
Member

Mte90 commented Oct 28, 2024

@b1ek there are conflicts in this PR

@Ph0enixKM
Copy link
Member

I want others to take a look as well

src/compiling/lexing/lexer.rs Outdated Show resolved Hide resolved
src/compiling/lexing/reader.rs Outdated Show resolved Hide resolved
@hdwalters
Copy link
Contributor

I'm not that familiar with feature support in Rust crates, but it looks like you're creating a new feature in the heraclitus crate, which in turn enables serialization/deserialization feature in the serde crate. Can I assume you've confirmed that the amber project is successfully built against your local heraclitus changes, both with and without this feature enabled?

@b1ek
Copy link
Member Author

b1ek commented Nov 14, 2024

Can I assume you've confirmed that the amber project is successfully built against your local heraclitus changes, both with and without this feature enabled?

that is correct, i tested it before posting the PR

i just tested it now, it breaks some dependency versions with it enabled, but nothing that can't be fixed in 5 minutes

@b1ek b1ek requested a review from hdwalters November 14, 2024 05:03
@b1ek b1ek merged commit 35a65e6 into master Nov 14, 2024
1 check passed
@b1ek b1ek deleted the serde-feature branch November 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants