Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging fails on Python 3.9 #46

Closed
ivelin opened this issue Jan 12, 2021 · 3 comments · Fixed by #47
Closed

Packaging fails on Python 3.9 #46

ivelin opened this issue Jan 12, 2021 · 3 comments · Fixed by #47
Labels
bug Something isn't working help wanted Extra attention is needed released

Comments

@ivelin
Copy link
Contributor

ivelin commented Jan 12, 2021

See #45 and #44 .

@ivelin ivelin added bug Something isn't working help wanted Extra attention is needed labels Jan 12, 2021
@ivelin ivelin linked a pull request Jan 12, 2021 that will close this issue
@amotl
Copy link
Contributor

amotl commented Jan 13, 2021

Hi Ivelin,

when exploring the root cause

src/av/codec/codec.c:6117:36: error: ‘AV_CODEC_CAP_HARDWARE’ undeclared (first use in this function); did you mean ‘AV_CODEC_CAP_DR1’?

I found PyAV-Org/PyAV#651 and aiortc/aiortc#326, which somehow suggest the build needs ffmpeg >= 4 and maybe other updated libraries.

Apart from that, PyAV-Org/PyAV#619 (comment) states that

As of PyAV 8.0.0, binary wheels are provided which will greatly simplify installation and should solve your issue.

Unfortunately, there are no binary wheels for Python 3.9 yet, see [1]. @Odianosen25 observed the same within PyAV-Org/PyAV#697. So, we probably should add a friendly question at [2], asking whether building and uploading binary wheels for Python 3.9 to PyPI would be possible.

With kind regards,
Andreas.

[1] https://pypi.org/project/av/#files
[2] https://github.com/PyAV-Org/PyAV/issues

@amotl
Copy link
Contributor

amotl commented Jan 13, 2021

... which somehow suggest the build needs ffmpeg >= 4 and maybe other updated libraries.

Apparently, all dependency packages regarding ffmpeg and friends are satisfied with ubuntu-20.04 already. So, #47 will fix the build on GHA.

We probably should add a friendly question at [2], asking whether building and uploading binary wheels for Python 3.9 to PyPI would be possible.

That still holds true and will make installation for downstream users easier.

[2] https://github.com/PyAV-Org/PyAV/issues

@ivelin ivelin linked a pull request Jan 14, 2021 that will close this issue
ivelin pushed a commit that referenced this issue Jan 14, 2021
Attempt to fix the GHA build on Python 3.9
@ivelin
Copy link
Contributor Author

ivelin commented Jan 15, 2021

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed released
Projects
None yet
2 participants