Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(node): add node 20 support #48

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Feb 1, 2024

Description

Use node 20 in workflow files.
Add node 20 to test matrix.

Motivation and Context

Node 20 is LTS.

How Has This Been Tested?

Ran tests using node 20.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for vitruvius users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using vitruvius?

@JAdshead JAdshead requested review from a team as code owners February 1, 2024 20:04
@10xLaCroixDrinker 10xLaCroixDrinker merged commit 1db175c into main Feb 1, 2024
3 checks passed
@10xLaCroixDrinker 10xLaCroixDrinker deleted the chore/node-20-support branch February 1, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants