Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(commit-lint): warn footer line length #49

Merged
merged 1 commit into from
Feb 2, 2024
Merged

chore(commit-lint): warn footer line length #49

merged 1 commit into from
Feb 2, 2024

Conversation

JAdshead
Copy link
Contributor

@JAdshead JAdshead commented Feb 2, 2024 •
edited
Loading

Description

commit lint- warn on footer line length rule

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change impacts caching for client browsers.
  • This change adds additional environment variable requirements for vitruvius users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using vitruvius?

@JAdshead
chore(commit-lint): warn footer line length
a007c1c 
this is a long body message as we need to test if the line length is actually working, i think i need even more characters to make this thing fail. ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

this is going to be a reaaaaaalllllyyyy long footer. ahhhhhhhhhhhhhhhhhhhhhhhhhhhhhh bbbbbbbbbbbbbbbbbbbbbbbbb ccccccccccccccccccccc ddddddddddddddddddddddddd eeeeeeeeeeeeeeeeeeeeee
@JAdshead JAdshead requested review from a team as code owners February 2, 2024 17:12
@JAdshead JAdshead enabled auto-merge (squash) February 2, 2024 17:31
@Matthew-Mallimo Matthew-Mallimo requested a review from a team February 2, 2024 17:53
@JAdshead JAdshead merged commit d66acf4 into main Feb 2, 2024
4 checks passed
@JAdshead JAdshead deleted the test/commit branch February 2, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishnubista bishnubista bishnubista approved these changes

@Matthew-Mallimo Matthew-Mallimo Matthew-Mallimo approved these changes

Assignees
No one assigned
Labels
one-app-team-review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JAdshead @Matthew-Mallimo @bishnubista