Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging of fts and cartesian wrenches on left and right arm and right upper leg when using iCubGazeboV3 #525

Merged
merged 5 commits into from
Apr 27, 2022
Merged

Add logging of fts and cartesian wrenches on left and right arm and right upper leg when using iCubGazeboV3 #525

merged 5 commits into from
Apr 27, 2022

Conversation

isorrentino
Copy link
Collaborator

No description provided.

@isorrentino isorrentino self-assigned this Apr 9, 2022
GiulioRomualdi
GiulioRomualdi reviewed Apr 9, 2022
View reviewed changes
Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

prashanthr05
prashanthr05 approved these changes Apr 9, 2022
View reviewed changes
Copy link
Collaborator

@prashanthr05 prashanthr05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isorrentino maybe this would be a good time to reorganize the multiple FT sensors files into a single file for better maintenance?

I was also wondering if we should start moving towards Multiple Analog Sensors for the FTs since analog sensors are getting deprecated?

@isorrentino
Copy link
Collaborator Author

@isorrentino maybe this would be a good time to reorganize the multiple FT sensors files into a single file for better maintenance?

Maybe I can start adding this modification to this PR.

I was also wondering if we should start moving towards Multiple Analog Sensors for the FTs since analog sensors are getting deprecated?

and leave this for a new PR. @prashanthr05 what do you think?

@prashanthr05
Copy link
Collaborator

Yep, that would be neater.

@isorrentino
Copy link
Collaborator Author

@isorrentino maybe this would be a good time to reorganize the multiple FT sensors files into a single file for better maintenance?

Hi @prashanthr05,

I added the modifications in the latest commit.

@isorrentino
Copy link
Collaborator Author

Friendly ping @prashanthr05 @GiulioRomualdi

@GiulioRomualdi
Copy link
Member

@isorrentino can you please update the changelog adding this: #525 (comment)

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Apr 27, 2022 •
edited
Loading

I will merge the PR after this #525 (comment) even if the CI is failing. Indeed this modification do not affect the compilation issue we are experiencing in the CI

@isorrentino
Copy link
Collaborator Author

Done @GiulioRomualdi

@GiulioRomualdi GiulioRomualdi merged commit 639c53b into ami-iit:master Apr 27, 2022
@isorrentino isorrentino deleted the addLoggingAllFTsiCubGazeboV3 branch April 17, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiulioRomualdi GiulioRomualdi GiulioRomualdi left review comments

@prashanthr05 prashanthr05 prashanthr05 approved these changes

Assignees

@isorrentino isorrentino

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isorrentino @prashanthr05 @GiulioRomualdi