-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to compute the Jacobian derivative of additional frames rigidly attached to links #210
Conversation
This test checks that the bias acceleration of a frame obtained by computing J dot @ nu JaxSim corresponds to the same quantity obtained through KinDynComputations
I created this draft PR to share my code in an easy way with you. However the test is failing for two reasons:
|
In b747a26 I commented out the test against iDynTree and tried to test directly |
addc9f0
to
3c5e544
Compare
In 78b690d I also explicitly handled the conversion of the input representation of the jacobian via matrix I suspect something here: jaxsim/src/jaxsim/api/frame.py Lines 400 to 423 in 78b690d
@diegoferigo @flferretti any idea? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some time to go through you code, but the following is definitely a bug. Let's see what happens as soon as you fix it.
Co-authored-by: Diego Ferigo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just minor suggestions.
Co-authored-by: diegoferigo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great @xela-95, thanks a lot! LGTM
Closes #208
📚 Documentation preview 📚: https://jaxsim--210.org.readthedocs.build//210/