Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI/CD workflow #29

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Update CI/CD workflow #29

merged 3 commits into from
Mar 8, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 8, 2024

For reason that I don't understand it no longer gets triggered. @traversaro any clue?

Furthermore:

@diegoferigo diegoferigo self-assigned this Mar 8, 2024
@traversaro
Copy link
Contributor

If you go in https://github.com/ami-iit/rod/actions/workflows/ci_cd.yml you see that it has been de-activated due to inactivity. You can re-enable it there.

@diegoferigo
Copy link
Member Author

Interesting, I visited that page while trying to understand the reason but I didn't notice the warning. Thanks and sorry for the noise.

@traversaro
Copy link
Contributor

Interesting, I visited that page while trying to understand the reason but I didn't notice the warning. Thanks and sorry for the noise.

Yes, indeed it is not super-clear, even as there is no kind of notice in the PR, where the PR status is silently green.

@diegoferigo
Copy link
Member Author

Interesting, I visited that page while trying to understand the reason but I didn't notice the warning. Thanks and sorry for the noise.

Yes, indeed it is not super-clear, even as there is no kind of notice in the PR, where the PR status is silently green.

Worse part is that I tried to make a release, and nothing showed up in PyPI xD That's how I noticed that something was missing.

@diegoferigo diegoferigo marked this pull request as ready for review March 8, 2024 14:15
@diegoferigo diegoferigo changed the title Fix CI/CD workflow Update CI/CD workflow Mar 8, 2024
@diegoferigo diegoferigo requested review from traversaro and removed request for traversaro March 8, 2024 14:17
@diegoferigo diegoferigo merged commit f63965c into main Mar 8, 2024
40 checks passed
@diegoferigo diegoferigo deleted the diegoferigo-patch-1 branch March 8, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants