Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPDocs & Reformation & Refactoring #16

Merged
merged 6 commits into from
May 20, 2020
Merged

PHPDocs & Reformation & Refactoring #16

merged 6 commits into from
May 20, 2020

Conversation

amirkhiz
Copy link
Owner

  • Complete PHPDocs for all API endpoints with doc link
  • Add new helper method to check empty parameters
  • Reformation

@amirkhiz
Copy link
Owner Author

Hi @rytisder,
Could you please test this branch for Helper::fillParameters() method uses.
I used this method to check empty parameters in different classes also in Actions::class.
At this time I do not have time to have test with real API.
Thanks.

@rytisder
Copy link
Collaborator

sure, @amirkhiz! Will do it on Monday.

@rytisder
Copy link
Collaborator

@amirkhiz, I've tested fillParameters() and it does work as expected.

One more thing. Can you rerun PHPDocs on all files?
I've fixed incorrect response types from Helper.php.
Every API call except getXML() should return an array, because default value is 'json' for parse function. And if it's JSON type, then it goes through
case 'json': return json_decode((string)$response->getBody(), true); where true indicates that it should parse it as a associative array.

@rytisder
Copy link
Collaborator

Or later I will do it myself on this PR. I have a meeting now, so in a few hours, I will fix it. 🚀

@rytisder
Copy link
Collaborator

Done, @amirkhiz, please double-check it and we shall merge it. ⛰️

@amirkhiz
Copy link
Owner Author

@rytisder Thank you so much for fixing. 👍

@amirkhiz amirkhiz merged commit d586c5d into master May 20, 2020
@rytisder
Copy link
Collaborator

rytisder commented May 20, 2020

No Problem, @amirkhiz! 🥳

Take a look at this suggestion: #19

@rytisder rytisder deleted the phpdocs-completion branch May 20, 2020 13:28
@amirkhiz
Copy link
Owner Author

I checked that out thanks. good point. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants