Skip to content

Commit

Permalink
Merge pull request #3 from Azure/master
Browse files Browse the repository at this point in the history
Taking latest from upstream
  • Loading branch information
harics24 authored Mar 19, 2021
2 parents b7050b7 + 4001032 commit f6fe18b
Show file tree
Hide file tree
Showing 7,244 changed files with 855,758 additions and 20,496 deletions.
The diff you're trying to view is too large. We only load the first 3000 changed files.
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
### *This is an outdated document. Please refer the new [wiki](https://github.com/Azure/adx-documentation-pr/wiki) for up to date details.*
### *This is an outdated document. Please refer the new [wiki](https://github.com/Azure/azure-rest-api-specs/wiki) for up to date details.*
([`Link your GitHub account`](https://repos.opensource.microsoft.com/) to the 'Azure' organization for access.)

9 changes: 5 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Please ensure to add changelog with this PR by answering the following questions
- [ ] No, no need to refresh for updates in this PR

### Contribution checklist:
- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of no breaking changes
- [ ] I commit to follow the [Breaking Change Policy](http://aka.ms/bcforapi) of "no breaking changes"
- [ ] I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow.
- [ ] [Validation tools](https://aka.ms/swaggertools) were run on swagger spec(s) and errors have all been fixed in this PR. [How to fix?](https://aka.ms/ci-fix)

Expand All @@ -33,20 +33,21 @@ If any further question about AME onboarding or validation tools, please view th
- [ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
- Adding new API(s)
- Adding a new API version
- [ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
- Adding a new service

- [ ] Please ensure you've reviewed following [guidelines](https://aka.ms/rpguidelines) including [ARM resource provider contract](https://github.com/Azure/azure-resource-manager-rpc) and [REST guidelines](https://github.com/microsoft/api-guidelines/blob/vNext/azure/Guidelines.md). Estimated time (4 hours). This is required before you can request review from ARM API Review board.

- [ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (*RP Manifest Approvers* team under <ins>Azure Resource Manager service</ins>) from IcM and reach out to them.

### Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi).
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the [Breaking Change Policy](http://aka.ms/bcforapi).

- [ ] Removing API(s) in stable version
- [ ] Removing properties in stable version
- [ ] Removing API version(s) in stable version
- [ ] Updating API in stable version with Breaking Change Validation errors
- [ ] Updating API(s) in preview over 1 year
- [ ] Updating API in stable or public preview version with Breaking Change Validation errors
- [ ] Updating API(s) in public preview over 1 year (refer to [Retirement of Previews](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37683/Retirement-of-Previews))

**Action**: to initiate an evaluation of the breaking change, create a new intake using the [template for breaking changes](https://aka.ms/Breakingchangetemplate). Addition details on the process and office hours are on the [Breaking change Wiki](https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/37684/Breaking-Changes).

Expand Down
6 changes: 6 additions & 0 deletions .github/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,10 @@
- "I have reviewed the [documentation](https://aka.ms/ameonboard) for the workflow."
onOpenedComments: "Hi, @${PRAuthor} Thanks for your PR. I am workflow bot for review process. Here are some small tips. </br> <li> Please ensure to do self-check against checklists in first PR comment.</li> <li> PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging. </li> <li> For specs comparison cross API versions, Use [API Specs Comparison Report Generator](${openapiHub}/tools/diff?pr=${owner}/${repo}/${PRNumber})</li> <li> If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. [How to fix?](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md)</li></br> Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected]"

- rule:
type: checkbox
keywords:
- "update existing version to fix swagger quality issue in s360"
onCheckedLabels:
- FixS360

34 changes: 18 additions & 16 deletions .github/pull_request_assignment.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
---
- rule:
# translator data-plane PR
paths:
- "specification/cognitiveservices/data-plane/TranslatorText/**"
reviewers:
- kristapratico
- maririos

- rule:
# eventgrid data-plane PR
paths:
Expand All @@ -11,7 +19,7 @@
paths:
- "specification/synapse/data-plane/**"
reviewers:
- jonathandturner
- lmazuel

- rule:
# data-plane PR
Expand All @@ -37,10 +45,15 @@
- kairu-ms

- rule:
paths: "specification/@(resources|powerplatform|appplatform)/**"
paths: "specification/@(resources|powerplatform|appplatform|deviceupdate)/**"
reviewers:
- raych1


- rule:
paths: "specification/@(security|edgeorder|synapse)/**"
reviewers:
- ruowan

- rule:
paths: "specification/sql/**"
reviewers:
Expand Down Expand Up @@ -78,7 +91,6 @@
- "specification/authorization/**"
reviewers:
- qianwens
- yungezz

- rule:
paths:
Expand Down Expand Up @@ -106,7 +118,7 @@
- allenjzhang
- rule:
paths:
- "specification/@(databricks|containerregistry)/**"
- "specification/containerregistry/**"
reviewers:
- fengzhou-msft

Expand All @@ -115,7 +127,6 @@
- "specification/@(containerservice|containerinstance)/**"
reviewers:
- PhoenixHe-msft
- yungezz

- rule:
paths:
Expand Down Expand Up @@ -146,7 +157,7 @@
paths:
- "specification/servicelinker/**"
reviewers:
- PhoenixHe-msft
- raych1

- rule:
paths:
Expand All @@ -162,12 +173,6 @@
- josefree
- akning-ms

- rule:
paths:
- "documentation/**"
reviewers:
- josefree
- akning-ms

- rule:
paths:
Expand All @@ -187,16 +192,13 @@
paths:
- "**"
reviewers:
- yungezz
- erich-wang
- PhoenixHe-msft
- lirenhe
- weidongxu-microsoft
- ArcturusZhang
- xccc-msft
- raych1
- ChenTanyi
- fengzhou-msft
- njuCZ
- akning-ms
- leni-msft
Expand Down
31 changes: 28 additions & 3 deletions .prettierrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,30 @@
{
"plugins": ["./scripts/prettier-swagger-plugin"],
"parser": "json-swagger",
"printWidth": 20
"overrides": [
{
"files": [
"specification/**/*.json",
"documentation/swagger-bootstrap.json",
"documentation/samplefiles/**/*.json"
],
"options": {
"plugins": [
"./scripts/prettier-swagger-plugin"
],
"parser": "json-swagger",
"printWidth": 20
}
},
{
"files": [
"**/*.json"
],
"options": {
"parser": "json",
"printWidth": 20
},
"excludeFiles": [
"specification/**/*.json"
]
}
]
}
7 changes: 7 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"recommendations": [
"EditorConfig.EditorConfig",
"esbenp.prettier-vscode",
"docsmsft.docs-authoring-pack"
]
}
27 changes: 27 additions & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
// Use IntelliSense to learn about possible attributes.
// Hover to view descriptions of existing attributes.
// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Mocha Tests",
"program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
"args": [
"--timeout",
"999999",
"--colors",
"${workspaceFolder}/test/syntax.js"
],
"internalConsoleOptions": "openOnSessionStart"
},
{
"type": "node",
"request": "launch",
"name": "Launch Program",
"program": "${file}"
}
]
}
27 changes: 27 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// Place your settings in this file to overwrite default and user settings.
{
"json.schemas": [
{
"fileMatch": [
"/**/specification/*.json"
],
"url": "https://raw.githubusercontent.com/Azure/autorest/master/packages/libs/autorest-schemas/swagger-extensions.json"
},
{
"fileMatch": [
"/**/examples/*.json"
],
"url": "https://raw.githubusercontent.com/Azure/autorest/master/packages/libs/autorest-schemas/example-schema.json"
},
{
"fileMatch": [
"/**/composite*.json"
],
"url": "https://raw.githubusercontent.com/Azure/autorest/master/packages/libs/autorest-schemas/composite-swagger.json"
}
],
"typescript.tsdk": "node_modules\\typescript\\lib",
"[json]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
}
}
11 changes: 8 additions & 3 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/specification/adp/ @Azure/adp
/specification/analysisservices/ @taiwu
/specification/alertsmanagement/ @ofirmanor @olalavi @erangon @orieldar @ilaizi @shakednai1 @khaboasb @orenhor
/specification/apimanagement/ @promoisha @solankisamir
Expand Down Expand Up @@ -49,7 +50,7 @@
/specification/operationalinsights/ @sw47
/specification/operationsmanagement/ @dashimi16
/specification/peering/ @rileymckenna
/specification/policyinsights/ @bulentelmaci
/specification/policyinsights/ @pilor
/specification/postgresql/ @qingqingyuan
/specification/powerbidedicated/ @tarostok
/specification/provisioningservices/ @kvish
Expand All @@ -60,7 +61,7 @@
/specification/relay/ @sethmanheim @v-ajnava
/specification/resources/ @Azure/arm-template-deployments @rajshah11 @vivsriaus
/specification/scheduler/ @pinwang81
/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy @heaths @AlexGhiondea
/specification/search/data-plane/ @brjohnstmsft @arv100kri @bleroy @heaths @AlexGhiondea @Mohit-Chakraborty
/specification/search/resource-manager/ @abhi1509 @miwelsh @tjacobhi
/specification/serialconsole/ @amitchat @craigw @asinn826
/specification/service-map/ @daveirwin1
Expand All @@ -78,4 +79,8 @@
/specification/trafficmanager/ @allencal @hrkulkarmsft
/specification/web/ @naveedaz @Azure/azure-app-service-control-plane
/profile/ @shahabhijeet
/specification/**/*.md @lirenhe
/specification/**/resource-manager/**/readme.typescript.md @qiaozha
/specification/**/resource-manager/**/readme.az.md @jsntcy @qiaozha
/specification/**/resource-manager/**/readme.cli.md @jsntcy @qiaozha
/specification/**/resource-manager/**/readme.go.md @ArcturusZhang
/specification/**/resource-manager/**/readme.python.md @jsntcy @msyyc
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
This repository is the canonical source for REST API specifications for Microsoft Azure.

## Getting started
If you're a Microsoft employee looking for information about all of the repositories and steps in the pipeline, go to our [documentation](https://github.com/Azure/adx-documentation-pr/wiki) repository. Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that repo.
If you're a Microsoft employee looking for information about all of the repositories and steps in the pipeline, go to the [Azure SDK - Internal Wiki](https://aka.ms/jointhesdk). Make sure to [join the Github Azure organization](http://aka.ms/azuregithub) to get access to that wiki repo. If any trouble with access, please submit a support request using this [form](https://aka.ms/swaggerfeedback).

<b>Latest improvement:</b><i> Microsoft employees can try out our new experience at [OpenAPI Hub](https://aka.ms/openapihub) - online experience for using our validation tools and finding your workflow.</i>

Expand Down Expand Up @@ -82,7 +82,7 @@ The structure should appear like so:
Currently, the specifications are expected to be in Swagger JSON format

## Next steps
The next step in the process after a spec is completed is to generate SDKs and API reference documentation. If you're Microsoft employee, go to the [Azure Developer Experience guide](https://github.com/Azure/adx-documentation-pr) for more information.
The next step in the process after a spec is completed is to generate SDKs and API reference documentation. If you're Microsoft employee, go to the [Azure SDK - Internal Wiki](https://aka.ms/jointhesdk) for more information.

---
_This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [[email protected]](mailto:[email protected]) with any additional questions or comments._
Loading

0 comments on commit f6fe18b

Please sign in to comment.