W-11460908: remove full JSON path from property terms in JSON-LD objects #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pope1838
previously approved these changes
May 9, 2023
nschejtman
force-pushed
the
W-11460908
branch
2 times, most recently
from
ce3b427
to
cb7d00a
Compare
| @@ -39,11 +39,19 @@ case class JsonLDObjectElementParser( | |||
| override def findClassTerm(ctx: SemanticContext): Seq[String] = { | |||
| val terms = super.findClassTerm(ctx).map(ctx.expand) | |||
| if (terms.isEmpty) { | |||
| val fragment = if (path.toString.isEmpty) key else path.toString | |||
| val fragment = lastNameFromPath() match { | |||
There was a problem hiding this comment.
this whole if-clause could be refactored into a method so we isolate @id computation logic
| .getOrElse(semanticContext.computeBase(name)) | ||
|
|
||
| // should be unreachable | ||
| case _ => throw new IllegalStateException(s"Property ${path.toString} does not have name") |
There was a problem hiding this comment.
[Out of Scope] - This is shady, we should have a safe-compiler way of doing this check (I don't know how at the moment)
tomsfernandez
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.