Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W 13823763 #1834

Merged
merged 9 commits into from
Aug 31, 2023
Merged

W 13823763 #1834

merged 9 commits into from
Aug 31, 2023

Conversation

nschejtman
Copy link
Contributor

  • Remove apparently dead code
  • W-13823763: normalize union members when computing inheritance with parent union and child node shape
  • Refactor: move nested minShape calls from MinShapeAlgorithm from context to resolver
  • wip - fix tests

@nschejtman nschejtman force-pushed the W-13823763 branch 2 times, most recently from 8847640 to a22af4d Compare August 24, 2023 19:43
@terminology-check-aml
Copy link

This PR contains some terms that are considered warnings according to the Inclusive Product Language initiative

  • amf-cli/shared/src/test/resources/production/missing-property-inherits.raml: master
  • amf-cli/shared/src/test/resources/production/object-inherits-union.raml: master
    Please, use other terminology for the found warnings. You can follow the suggested replacements described here.

@pope1838 pope1838 marked this pull request as ready for review August 31, 2023 12:48
@pope1838 pope1838 merged commit c0f491b into develop Aug 31, 2023
4 checks passed
@pope1838 pope1838 deleted the W-13823763 branch August 31, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@looseale looseale looseale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nschejtman @looseale @pope1838