W 12689960 New field at messages: MessageId #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianpedra
force-pushed
the
W-12689960
branch
from
d9eb192
to
5cff6d1
Compare
looseale
reviewed
Feb 27, 2024
| parseMessageId(map, message) | ||
| } | ||
| message | ||
| // map.key("messageId", MessageModel.MessageId in message) |
| val messageId = entry.value.toString() | ||
| if (!ctx.registerMessageId(messageId)) | ||
| ctx.eh.violation( | ||
| ParserSideValidations.DuplicatedMessageId, message, s"duplicado $messageId", entry.value.location |
There was a problem hiding this comment.
Fix error message "duplicado"
| validate("double-references/valid-ref-to-parameter-with-ref.yaml") | ||
| } | ||
|
|
||
| test("Valid ref to bindings with another ref") { |
There was a problem hiding this comment.
Why all these deleted lines?
damianpedra
force-pushed
the
W-12689960
branch
3 times, most recently
from
8f6bef0
to
f7ad481
Compare
…fferent scenarios
damianpedra
force-pushed
the
W-12689960
branch
from
f7ad481
to
b37451c
Compare
looseale
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New field at messages: MessageId