Add simple handling/workaround for chained quantifiers #69
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ammar wanna take a look?
this adds support for chained quantifiers by wrapping their targets in passive groups.
it modifies the node tree while parsing, similar to the treatment of alternations, ranges in sets etc.
this seems to be the most pragmatic way to handle these edge cases. existing integrations of the gem will keep working without effort, and if someone really wants to treat these cases in a special way, they can check
#implicit?
.i also explored some other approaches, which seemed worse:
Quantifier
objects to have a#quantifier
themselves#quantifier
with#quantifiers
returning an Array ofQuantifier
objects for all expressions2
, but leavingdef quantifier; quantifiers[0] end
as a fallback1