-
-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glob monkey patch missing recursive
argument in Python 3.5
#341
Labels
Comments
This was referenced Dec 16, 2016
This was referenced Jan 4, 2017
0-wiz-0
added a commit
to NetBSD/pkgsrc-wip
that referenced
this issue
Jan 18, 2017
Test status: FAILED (failures=1, errors=7, skipped=2) * added `_bg_exc` for silencing exceptions in background threads [#350](amoffat/sh#350) * bugfix for patched glob.glob on python3.5 [#341](amoffat/sh#341)
This was referenced Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, in your newest release the "monkey patch" of
glob.glob
breaks user code, if one tries to set therecursive
argument that the originalglob.glob
implementation provides in Python 3.5 (see Python 3.5 docs).Demonstration:
I guess adding
args
andkwargs
to yourglob
wrapper might fix this and makes you independent of the function signature of the actualglob
implementation. Suggested diff onsh.py
:Many thanks for your great work! ;)
edit: fixed order in the diff
The text was updated successfully, but these errors were encountered: