Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit messages aren't fully shell escaped #164

Open
yolken-airplane opened this issue Jun 24, 2022 · 0 comments · May be fixed by #165
Open

Commit messages aren't fully shell escaped #164

yolken-airplane opened this issue Jun 24, 2022 · 0 comments · May be fixed by #165
Assignees
@amondnet
Labels
Type: Bug Bug or Bug fixes

Comments

@yolken-airplane
Copy link

yolken-airplane commented Jun 24, 2022 •
edited
Loading

We've noticed that if a commit message has backticks in it, then the action fails because the shell tries to execute the text between the backticks:

Screen Shot 2022-06-24 at 10 47 12 AM

I think this can be fixed by removing backticks in the commit here: https://github.com/amondnet/vercel-action/blob/master/index.js#L135.
@yolken-airplane yolken-airplane changed the title Commit messages aren't shell escaped Commit messages aren't fully shell escaped Jun 25, 2022
@amondnet amondnet added the Type: Bug Bug or Bug fixes label Jun 27, 2022
@amondnet amondnet self-assigned this Jun 27, 2022
amondnet added a commit that referenced this issue Jun 27, 2022
@amondnet
fix: Commit messages aren't fully shell escaped
9ef9eef 
close #164
close #162

Signed-off-by: Minsu Lee <[email protected]>
@amondnet amondnet linked a pull request Jun 27, 2022 that will close this issue
fix: Commit messages aren't fully shell escaped #165
Open
@amondnet amondnet linked a pull request Jun 27, 2022 that will close this issue
Open
amondnet added a commit that referenced this issue Jun 27, 2022
@amondnet
fix: Commit messages aren't fully shell escaped
9b20fa7 
close #164
close #162

Signed-off-by: Minsu Lee <[email protected]>
amondnet added a commit that referenced this issue Jun 27, 2022
@amondnet
fix: Commit messages aren't fully shell escaped
8ed64b8 
`foo`, 'bar', "baz"

close #164
close #162

Signed-off-by: Minsu Lee <[email protected]>
amondnet added a commit that referenced this issue Jun 27, 2022
@amondnet
fix: Commit messages aren't fully shell escaped
b818161 
`app` , "test", 'foo'

close #164
close #162

Signed-off-by: Minsu Lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amondnet amondnet

Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Commit messages aren't fully shell escaped amondnet/vercel-action
2 participants
@amondnet @yolken-airplane