Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly format client_upload_time in HTTP request when minIdLength is set #160

Merged
merged 3 commits into from
Nov 13, 2023
Merged

fix: correctly format client_upload_time in HTTP request when minIdLength is set #160

merged 3 commits into from
Nov 13, 2023

Conversation

justin-fiedler
Copy link
Contributor

@justin-fiedler justin-fiedler commented Nov 13, 2023 •
edited by jira bot
Loading

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Mercy811
Mercy811 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Mercy811 Mercy811 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Justin for fixing the payload and adding tests.

core/src/test/kotlin/com/amplitude/core/utilities/HttpClientTest.kt Outdated Show resolved Hide resolved
@justin-fiedler justin-fiedler merged commit f5203a5 into main Nov 13, 2023
2 checks passed
@justin-fiedler justin-fiedler deleted the AMP-88899-malformed-client_upload_time branch November 13, 2023 21:50
github-actions bot pushed a commit that referenced this pull request Nov 13, 2023
@amplitude-sdk-bot
chore(release): 1.12.2 [skip ci]
0315e8e 
## [1.12.2](v1.12.1...v1.12.2) (2023-11-13)

### Bug Fixes

* correctly format client_upload_time in HTTP request when minIdLength is set ([#160](#160)) ([f5203a5](f5203a5))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.12.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercy811 Mercy811 Mercy811 approved these changes

@qingzhuozhen qingzhuozhen Awaiting requested review from qingzhuozhen

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Malformed Event(s) JSON using 1.12.0 SDK
2 participants
@justin-fiedler @Mercy811