Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extract ComposeUtils to share with plugins #202

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix: extract ComposeUtils to share with plugins #202

merged 3 commits into from
Jun 27, 2024

Conversation

justin-fiedler
Copy link
Contributor

Summary

  • extract ComposeUtils to share with plugins

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

PouriaAmini
PouriaAmini approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@PouriaAmini PouriaAmini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Justin, LGTM! Some builds are failing though.

@justin-fiedler justin-fiedler merged commit c239bba into main Jun 27, 2024
4 checks passed
@justin-fiedler justin-fiedler deleted the AMP-102931-try-autocomplete-scanning-of-compose-views branch June 27, 2024 23:11
github-actions bot pushed a commit that referenced this pull request Aug 8, 2024
@amplitude-sdk-bot
chore(release): 1.17.0 [skip ci]
d20a072 
# [1.17.0](v1.16.8...v1.17.0) (2024-08-08)

### Bug Fixes

* extract ComposeUtils to share with plugins ([#202](#202)) ([c239bba](c239bba))
* fix release pipeline ([#211](#211)) ([816599f](816599f))
* revert autocapture scroll and swipe ([#206](#206)) ([4b834bd](4b834bd))

### Features

* add autocapture for element clicks ([#199](#199)) ([7f0a500](7f0a500))
* add autocapture in configs ([#207](#207)) ([dcb9393](dcb9393))
* add screen name to elementInteractions properties for autocapture ([#209](#209)) ([8044122](8044122))
* add scroll and swipe autocapture ([#201](#201)) ([1a5a392](1a5a392))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PouriaAmini PouriaAmini PouriaAmini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin-fiedler @PouriaAmini