fix: Catch network connectivity exceptions #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crleona
approved these changes
Aug 21, 2024
android/src/main/java/com/amplitude/android/utilities/ExceptionUtils.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/amplitude/android/utilities/AndroidNetworkConnectivityChecker.kt
Outdated
Show resolved
Hide resolved
Mercy811
reviewed
Aug 21, 2024
There was a problem hiding this comment.
Thanks Izaaz for fixing this. As it's a known issue and 99% of devices affected are Pixel devices (2/3) running android 11 according to https://issuetracker.google.com/issues/175055271. Wrapping where exceptions are thrown makes sense to me.
android/src/main/java/com/amplitude/android/utilities/AndroidNetworkListener.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/amplitude/android/utilities/AndroidNetworkConnectivityChecker.kt
Outdated
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
## [1.17.4](v1.17.3...v1.17.4) (2024-08-21) ### Bug Fixes * Catch network connectivity exceptions ([#221](#221)) ([1ed787b](1ed787b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #197 and #220
The network connectivity checker can throw an exception sometimes that causes the app to crash. Wrap them around try catches, suppress exceptions and default to online in case of an error
Checklist