feat: Stab to integrate current connector and extract identity storage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingzhuozhen
changed the title
qingzhuozhen
requested review from
bgiori,
justin-fiedler and
kevinpagtakhan
qingzhuozhen
force-pushed
the
identity-stab-draft
branch
from
cf508d5
to
1873290
Compare
Comment on lines
+120
to
+122
| val safeListeners = synchronized(listenersLock) { | ||
| listeners.toSet() | ||
| } |
There was a problem hiding this comment.
curious what this does and what happens if not all listeners are returned?
There was a problem hiding this comment.
I guess the toSet is just to reduce the duplicate listeners
|
|
||
| init { | ||
| require(configuration.isValid()) { "invalid configuration" } | ||
| timeline = Timeline().also { it.amplitude = this } | ||
| storage = configuration.storageProvider.getStorage(this) | ||
| logger = configuration.loggerProvider.getLogger(this) | ||
| idContainer = IdContainer.getInstance(configuration.apiKey, IMIdentityStorageProvider()) | ||
| idContainer.identityStore.addIdentityListener(AnalyticsIdentityListener(store)) |
There was a problem hiding this comment.
question, does this make amplitude client listen for changes happening outside? while this emits changes happening inside amplitude client?
There was a problem hiding this comment.
yeah, this connects to identity store, then we can have support plugins for changes happening outside
|
Closing this one and moving the change in #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a stab effort to collect feedbacks on how we incorporate the current connector, and extract identity storage, and also how our observe plugin integrates together.
The earlier commits are based on #4. Please ignore when review this change.
Checklist