Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Context plugin #8

Merged
merged 3 commits into from
Nov 23, 2022
Merged

feat: Context plugin #8

merged 3 commits into from
Nov 23, 2022

Conversation

yuhao900914
Copy link
Contributor

Summary

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

liuyang1520
liuyang1520 reviewed Nov 23, 2022
View reviewed changes
Sources/Amplitude/Plugins/ContextPlugin.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/ContextPlugin.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/AppUtil.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/AppUtil.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/VendorSystem.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/VendorSystem.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/VendorSystem.swift Outdated Show resolved Hide resolved
Sources/Amplitude/Plugins/Vendors/VendorSystem.swift Outdated Show resolved Hide resolved
Tests/AmplitudeTests/AmplitudeTests.swift Outdated Show resolved Hide resolved
liuyang1520
liuyang1520 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@liuyang1520 liuyang1520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, could you please fix the lint and tests?

@liuyang1520 liuyang1520 merged commit 64ba783 into main Nov 23, 2022
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
@amplitude-sdk-bot
chore(release): 1.0.0 [skip ci]
cda1927 
# 1.0.0 (2022-12-15)

### Bug Fixes

* add lifecycle plugin ([a26c621](a26c621))
* add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b))
* add return to IdentityEventSender.execute ([75d787e](75d787e))
* add the placeholder for IdentityEventSender ([2ad97da](2ad97da))
* change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a))
* fix based on comments ([4f354bc](4f354bc))
* fix logger in destination ([a7ff24e](a7ff24e))
* fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1))
* fix timeline in destination plugin ([0767751](0767751))
* lints and other comments ([296951b](296951b))
* nits ([2e264a5](2e264a5))
* pass amplitude instance in plugin setup ([42fbb51](42fbb51))
* typo and types ([fe5dba7](fe5dba7))
* update support watchOS version ([5cc61f2](5cc61f2))

### Features

* add class and file placeholders ([d824cf1](d824cf1))
* add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28))
* add timeline ([7cda5b2](7cda5b2))
* Context plugin ([#8](#8)) ([64ba783](64ba783))
* destination plugin ([4dc18d9](4dc18d9))
* identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0))
* idfa plugin example ([#17](#17)) ([9104e5f](9104e5f))
* main function implementation ([29645c0](29645c0))
* persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f))
* response retry handlers ([#11](#11)) ([86d92f6](86d92f6))
* session event init ([#13](#13)) ([bbf7517](bbf7517))
* setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96))
* support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
@amplitude-sdk-bot
chore(release): 1.0.0 [skip ci]
388dc64 
# 1.0.0 (2022-12-15)

### Bug Fixes

* add lifecycle plugin ([a26c621](a26c621))
* add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b))
* add return to IdentityEventSender.execute ([75d787e](75d787e))
* add the placeholder for IdentityEventSender ([2ad97da](2ad97da))
* change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a))
* fix based on comments ([4f354bc](4f354bc))
* fix logger in destination ([a7ff24e](a7ff24e))
* fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1))
* fix timeline in destination plugin ([0767751](0767751))
* lints and other comments ([296951b](296951b))
* nits ([2e264a5](2e264a5))
* pass amplitude instance in plugin setup ([42fbb51](42fbb51))
* typo and types ([fe5dba7](fe5dba7))
* update support watchOS version ([5cc61f2](5cc61f2))

### Features

* add class and file placeholders ([d824cf1](d824cf1))
* add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28))
* add timeline ([7cda5b2](7cda5b2))
* Context plugin ([#8](#8)) ([64ba783](64ba783))
* destination plugin ([4dc18d9](4dc18d9))
* identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0))
* idfa plugin example ([#17](#17)) ([9104e5f](9104e5f))
* main function implementation ([29645c0](29645c0))
* persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f))
* response retry handlers ([#11](#11)) ([86d92f6](86d92f6))
* session event init ([#13](#13)) ([bbf7517](bbf7517))
* setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96))
* support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Dec 15, 2022
@amplitude-sdk-bot
chore(release): 0.1.0 [skip ci]
1323f65 
# [0.1.0](v0.0.0...v0.1.0) (2022-12-15)

### Bug Fixes

* add lifecycle plugin ([a26c621](a26c621))
* add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b))
* add return to IdentityEventSender.execute ([75d787e](75d787e))
* add the placeholder for IdentityEventSender ([2ad97da](2ad97da))
* change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a))
* fix based on comments ([4f354bc](4f354bc))
* fix logger in destination ([a7ff24e](a7ff24e))
* fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1))
* fix timeline in destination plugin ([0767751](0767751))
* lints and other comments ([296951b](296951b))
* nits ([2e264a5](2e264a5))
* pass amplitude instance in plugin setup ([42fbb51](42fbb51))
* typo and types ([fe5dba7](fe5dba7))
* update support watchOS version ([5cc61f2](5cc61f2))

### Features

* add class and file placeholders ([d824cf1](d824cf1))
* add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28))
* add timeline ([7cda5b2](7cda5b2))
* Context plugin ([#8](#8)) ([64ba783](64ba783))
* destination plugin ([4dc18d9](4dc18d9))
* identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0))
* idfa plugin example ([#17](#17)) ([9104e5f](9104e5f))
* main function implementation ([29645c0](29645c0))
* persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f))
* response retry handlers ([#11](#11)) ([86d92f6](86d92f6))
* session event init ([#13](#13)) ([bbf7517](bbf7517))
* setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96))
* support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
@justin-fiedler justin-fiedler deleted the contextPlugin branch September 28, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuyang1520 liuyang1520 liuyang1520 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuhao900914 @liuyang1520