feat: support event callback and fix missing insert_id #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao900914
reviewed
Dec 8, 2022
Sources/Amplitude/Utilities/PersistentStorageResponseHandler.swift
Outdated
Show resolved
Hide resolved
Tests/AmplitudeTests/Utilities/PersistentStorageResponseHandlerTests.swift
Outdated
Show resolved
Hide resolved
yuhao900914
approved these changes
Dec 8, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
# 1.0.0 (2022-12-15) ### Bug Fixes * add lifecycle plugin ([a26c621](a26c621)) * add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b)) * add return to IdentityEventSender.execute ([75d787e](75d787e)) * add the placeholder for IdentityEventSender ([2ad97da](2ad97da)) * change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a)) * fix based on comments ([4f354bc](4f354bc)) * fix logger in destination ([a7ff24e](a7ff24e)) * fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1)) * fix timeline in destination plugin ([0767751](0767751)) * lints and other comments ([296951b](296951b)) * nits ([2e264a5](2e264a5)) * pass amplitude instance in plugin setup ([42fbb51](42fbb51)) * typo and types ([fe5dba7](fe5dba7)) * update support watchOS version ([5cc61f2](5cc61f2)) ### Features * add class and file placeholders ([d824cf1](d824cf1)) * add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28)) * add timeline ([7cda5b2](7cda5b2)) * Context plugin ([#8](#8)) ([64ba783](64ba783)) * destination plugin ([4dc18d9](4dc18d9)) * identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0)) * idfa plugin example ([#17](#17)) ([9104e5f](9104e5f)) * main function implementation ([29645c0](29645c0)) * persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f)) * response retry handlers ([#11](#11)) ([86d92f6](86d92f6)) * session event init ([#13](#13)) ([bbf7517](bbf7517)) * setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96)) * support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
# 1.0.0 (2022-12-15) ### Bug Fixes * add lifecycle plugin ([a26c621](a26c621)) * add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b)) * add return to IdentityEventSender.execute ([75d787e](75d787e)) * add the placeholder for IdentityEventSender ([2ad97da](2ad97da)) * change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a)) * fix based on comments ([4f354bc](4f354bc)) * fix logger in destination ([a7ff24e](a7ff24e)) * fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1)) * fix timeline in destination plugin ([0767751](0767751)) * lints and other comments ([296951b](296951b)) * nits ([2e264a5](2e264a5)) * pass amplitude instance in plugin setup ([42fbb51](42fbb51)) * typo and types ([fe5dba7](fe5dba7)) * update support watchOS version ([5cc61f2](5cc61f2)) ### Features * add class and file placeholders ([d824cf1](d824cf1)) * add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28)) * add timeline ([7cda5b2](7cda5b2)) * Context plugin ([#8](#8)) ([64ba783](64ba783)) * destination plugin ([4dc18d9](4dc18d9)) * identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0)) * idfa plugin example ([#17](#17)) ([9104e5f](9104e5f)) * main function implementation ([29645c0](29645c0)) * persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f)) * response retry handlers ([#11](#11)) ([86d92f6](86d92f6)) * session event init ([#13](#13)) ([bbf7517](bbf7517)) * setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96)) * support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 15, 2022
# [0.1.0](v0.0.0...v0.1.0) (2022-12-15) ### Bug Fixes * add lifecycle plugin ([a26c621](a26c621)) * add other platform lifecycle plugin and lints fix ([c3f9c5b](c3f9c5b)) * add return to IdentityEventSender.execute ([75d787e](75d787e)) * add the placeholder for IdentityEventSender ([2ad97da](2ad97da)) * change storage to use sync queue, fix retry issues ([#14](#14)) ([e2d824a](e2d824a)) * fix based on comments ([4f354bc](4f354bc)) * fix logger in destination ([a7ff24e](a7ff24e)) * fix the demo app to fit ipad ([#12](#12)) ([72b1ef1](72b1ef1)) * fix timeline in destination plugin ([0767751](0767751)) * lints and other comments ([296951b](296951b)) * nits ([2e264a5](2e264a5)) * pass amplitude instance in plugin setup ([42fbb51](42fbb51)) * typo and types ([fe5dba7](fe5dba7)) * update support watchOS version ([5cc61f2](5cc61f2)) ### Features * add class and file placeholders ([d824cf1](d824cf1)) * add podspec and release flow ([#18](#18)) ([ef1ff28](ef1ff28)) * add timeline ([7cda5b2](7cda5b2)) * Context plugin ([#8](#8)) ([64ba783](64ba783)) * destination plugin ([4dc18d9](4dc18d9)) * identify, revenue, amplitude client ([#16](#16)) ([ab847f0](ab847f0)) * idfa plugin example ([#17](#17)) ([9104e5f](9104e5f)) * main function implementation ([29645c0](29645c0)) * persistent storage, httpclient, eventpipeline ([#9](#9)) ([0b5e99f](0b5e99f)) * response retry handlers ([#11](#11)) ([86d92f6](86d92f6)) * session event init ([#13](#13)) ([bbf7517](bbf7517)) * setup lint, jira issue create, fix all file lint issues, update config ([0a34b96](0a34b96)) * support event callback and fix missing insert_id ([#15](#15)) ([1f746e8](1f746e8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist