Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: track touchUpInside for any element #203

Merged
merged 8 commits into from
Jul 26, 2024
+5 −2
Merged

fix: track touchUpInside for any element #203

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c29eb55
fix: just track touchupinside and valuechanged for some elements
PouriaAmini Jul 24, 2024
044f4fa
fix: fix tvos issue
PouriaAmini Jul 24, 2024
9b912c2
feat: capture control events
PouriaAmini Jul 25, 2024
d055a7e
Merge remote-tracking branch 'remote/feature-autocapture' into events
PouriaAmini Jul 25, 2024
c229eea
fix: remove row selected event
PouriaAmini Jul 26, 2024
0eb4053
fix: track any touchUpInside
PouriaAmini Jul 26, 2024
6ff078b
Merge remote-tracking branch 'remote/feature-autocapture' into events
PouriaAmini Jul 26, 2024
5ac7162
fix: capture image name as a fallback for buttons title
PouriaAmini Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Sources/Amplitude/Plugins/iOS/UIKitUserInteractions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,16 @@ extension UIView: ActionTrackable {
@objc func amp_shouldTrack(_ action: Selector, for target: Any?) -> Bool { false }
}

extension UIButton {
override var amp_title: String? { currentTitle }
extension UIControl {
override func amp_shouldTrack(_ action: Selector, for target: Any?) -> Bool {
actions(forTarget: target, forControlEvent: .touchUpInside)?.contains(action.description) ?? false
}
}

extension UIButton {
override var amp_title: String? { currentTitle ?? currentImage?.accessibilityIdentifier }
}

extension UISegmentedControl {
override var amp_title: String? { titleForSegment(at: selectedSegmentIndex) }
override func amp_shouldTrack(_ action: Selector, for target: Any?) -> Bool {
Expand Down
Loading