Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature Autocapture #209

Merged
merged 11 commits into from
Aug 8, 2024
Merged

feat: Feature Autocapture #209

merged 11 commits into from
Aug 8, 2024
+733 −78

Conversation

PouriaAmini
Copy link
Contributor

@PouriaAmini PouriaAmini commented Aug 8, 2024 •
edited
Loading

Summary

This PR deprecates the defaultTracking option of the Configuration class and adds the autocapture option. It also adds user interaction tracking with UIControl elements and UIGestureRecognizer objects in UIKit applications. To enable this option, include AutocaptureOptions.elementInteractions in the autocapture configuration.

New Autocapture configuration

let amplitude = Amplitude(configuration: Configuration(
    apiKey: "API_KEY",
    autocapture: [.sessions, .appLifecycles, .screenViews, .elementInteractions]
))
AMPConfiguration* configuration = [AMPConfiguration initWithApiKey:@"API_KEY"];
configuration.autocapture = [[AMPAutocaptureOptions alloc] initWithOptionsToUnion:@[
    AMPAutocaptureOptions.sessions,
    AMPAutocaptureOptions.appLifecycles,
    AMPAutocaptureOptions.screenViews,
    AMPAutocaptureOptions.elementInteractions
]];
Amplitude* amplitude = [Amplitude initWithConfiguration:configuration];

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

PouriaAmini and others added 11 commits July 12, 2024 14:22
@PouriaAmini
feat: add user interactions capture (#190)
83f1c92 
* Fix indentation issue

* feat: add user interactions capture

* fix: fix typo

* fix: remove support for UITextField action message capture

* refactor: add dispatch once for method swizzling

* fix: remove support for UISlider to reduce noise

* feat: add support for UITextField and UISlider event capture

* style: remove return keyword for one line functions

* fix: fix typo

* feat: add support for text field gained/lost focus

* fix: fix lint

* fix: remove tag as textfield title

* refactor: refactor title and shouldTrack

* refactor: add a protocol to track control elements
@PouriaAmini
Merge remote-tracking branch 'origin/feature-autocapture' into featur…
c0522a7 
…e-autocapture
@PouriaAmini
feat: add support for uitextview autocapture (#195)
3810e2c 
* Fix indentation issue

* feat: add user interactions capture

* fix: fix typo

* fix: remove support for UITextField action message capture

* refactor: add dispatch once for method swizzling

* fix: remove support for UISlider to reduce noise

* feat: add support for UITextField and UISlider event capture

* style: remove return keyword for one line functions

* fix: fix typo

* feat: add support for text field gained/lost focus

* fix: fix lint

* fix: remove tag as textfield title

* refactor: refactor title and shouldTrack

* refactor: add a protocol to track control elements

* refactor: guard on action name

* feat: add support for uitextview capture

* fix: disable action method tracking support for UITextView

* fix: fix lint issue

* style: remove amp_ prefix from objc methods
@PouriaAmini
feat: add support for gesture recognizer autocapture (#196)
956b313 
* Fix indentation issue

* feat: add user interactions capture

* fix: fix typo

* fix: remove support for UITextField action message capture

* refactor: add dispatch once for method swizzling

* fix: remove support for UISlider to reduce noise

* feat: add support for UITextField and UISlider event capture

* style: remove return keyword for one line functions

* fix: fix typo

* feat: add support for text field gained/lost focus

* fix: fix lint

* fix: remove tag as textfield title

* refactor: refactor title and shouldTrack

* refactor: add a protocol to track control elements

* refactor: guard on action name

* feat: add support for uitextview capture

* fix: disable action method tracking support for UITextView

* fix: fix lint issue

* style: remove amp_ prefix from objc methods

* feat: add support for gesture recognizers autocapture

* fix: fix lint issue

* fix: exclude unsupported gestures in tvos
@PouriaAmini
fix: track touchupinside and valuechanged only (#199)
8305d48 
* fix: just track touchupinside and valuechanged for some elements

* fix: fix tvos issue
@PouriaAmini
feat: capture control events for autocapture (#202)
6564e33 
* fix: just track touchupinside and valuechanged for some elements

* fix: fix tvos issue

* feat: capture control events

* fix: remove row selected event
@PouriaAmini
fix: track touchUpInside for any element (#203)
7e6f42a 
* fix: just track touchupinside and valuechanged for some elements

* fix: fix tvos issue

* feat: capture control events

* fix: remove row selected event

* fix: track any touchUpInside

* fix: capture image name as a fallback for buttons title
@PouriaAmini
fix: deprecate defaultTracking and add autocapture (#204)
8f6703e 
* fix: deprecate defaultTracking and add autocapture

* fix: fix schema for the new test

* fix: fix typo

* fix: fix typo

* fix: support optionset for autocapture options

* fix: fix autocaptureoptions test

* fix: fix failing test

* fix: simplified the logic to deprecate defaultTracking

* style: make autocapture options for objc as properties
@PouriaAmini
fix: disable swiftui support for autocapture (#206)
093eace 
* fix: disable swiftui support for autocapture

* fix: disable support for swiftui gesture recognizers autocapture

* fix: fix typo

* fix: filter scrolls for scrollable views

* fix: imporve support for swiftui
@PouriaAmini
fix: track screen name autocapture (#207)
f0f7c40 
* fix: change element viewController to screenName

* fix: remove title since it's already captured by screenName
@PouriaAmini
fix: track changes to defaultTracking after initialization (#208)
5c72cc0 
* fix: track changes to defaultTracking after initialization

* fix: replace defaultTracking with autocapture if changed

* fix: fix typo

* fix: fix nit

* style: rename parameter name
@PouriaAmini PouriaAmini changed the title Feature Autocapture feat: Feature Autocapture Aug 8, 2024
@PouriaAmini PouriaAmini merged commit 4ab5673 into main Aug 8, 2024
5 of 6 checks passed
@PouriaAmini PouriaAmini deleted the feature-autocapture branch August 8, 2024 17:50
github-actions bot pushed a commit that referenced this pull request Aug 8, 2024
@amplitude-sdk-bot
chore(release): 1.8.0 [skip ci]
c8c13fc 
# [1.8.0](v1.7.0...v1.8.0) (2024-08-08)

### Features

* Feature Autocapture ([#209](#209)) ([4ab5673](4ab5673)), closes [#190](#190) [#195](#195) [#196](#196) [#199](#199) [#202](#202) [#203](#203) [#204](#204) [#206](#206) [#207](#207) [#208](#208)
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crleona crleona crleona approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PouriaAmini @crleona