fix: notify plugins of internal sessionId changes #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhao900914
approved these changes
Sep 10, 2024
crleona
force-pushed
the
fix-internal-sessionid-changes
branch
from
728ea39
to
cf3702d
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
## [1.9.2](v1.9.1...v1.9.2) (2024-09-10) ### Bug Fixes * notify plugins of internal sessionId changes ([#224](#224)) ([61d43cf](61d43cf))
|
🎉 This PR is included in version 1.9.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Amplitude.setSessionIdis not called on internal session id updates. move the observer to the actual backing variable.Checklist