feat: update destination plugin to class #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyang1520
force-pushed
the
update-destination-plugin
branch
from
8d15786
to
044015f
Compare
liuyang1520
force-pushed
the
update-destination-plugin
branch
from
044015f
to
3f3f8af
Compare
qingzhuozhen
approved these changes
Dec 20, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [0.3.0](v0.2.0...v0.3.0) (2022-12-20) ### Features * update destination plugin to class ([#30](#30)) ([705e61f](705e61f))
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current
DestinationPluginis a protocol, but it cannot hold thetimelineproperty, so if user writes a newDestinationPlugin, needs to define a timeline as well, which shouldn't be needed.To make it work, change
DestinationPluginto a class, and due to Swift's PWT (https://stackoverflow.com/a/44706021), we provide a common implementation forsetupandexecute, which can be override to call.Checklist